Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(replay): Handle edge cases & more logging #8558

Merged
merged 1 commit into from
Jul 19, 2023
Merged

fix(replay): Handle edge cases & more logging #8558

merged 1 commit into from
Jul 19, 2023

Conversation

mydea
Copy link
Member

@mydea mydea commented Jul 17, 2023

This is a PR to this feature branch: #8407

  • Handle edge case where we stop multiple times (honestly no idea how this should happen, but apparently it can 😬 )
  • Add some more logging for state changes

We can hopefully eventually remove the traceInternals checks, but for now this is an easy solution for debugging in the beta....

@mydea mydea requested a review from billyvg July 17, 2023 15:28
@mydea mydea self-assigned this Jul 17, 2023
@mydea mydea force-pushed the fn/replay-session-renew-fixes branch 2 times, most recently from 7e54ff4 to 194b0da Compare July 17, 2023 15:36
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2023 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.95 KB (-0.01% 🔽)
@sentry/browser - ES5 CDN Bundle (minified) 69.13 KB (0%)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 20.28 KB (-0.01% 🔽)
@sentry/browser - ES6 CDN Bundle (minified) 60.38 KB (0%)
@sentry/browser - Webpack (gzipped + minified) 21.9 KB (0%)
@sentry/browser - Webpack (minified) 71.51 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.92 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 50.58 KB (-0.36% 🔽)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 30.11 KB (-0.74% 🔽)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 28.16 KB (-0.14% 🔽)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 49.41 KB (-0.05% 🔽)
@sentry/replay - Webpack (gzipped + minified) 43.03 KB (-0.3% 🔽)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 69.5 KB (-0.09% 🔽)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 61.81 KB (-0.04% 🔽)

@mydea mydea force-pushed the fn/replay-session-renew-fixes branch from 905ad14 to fead140 Compare July 18, 2023 08:29
@mydea mydea merged commit 9c29c8a into fn/replay-session-renew Jul 19, 2023
@mydea mydea deleted the fn/replay-session-renew-fixes branch July 19, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mydea @billyvg